From: Paul Eggert Date: Sun, 20 Nov 2011 03:19:22 +0000 (-0800) Subject: Standardize on VIRT_ADDR_VARIES behavior. X-Git-Tag: archive/raspbian/1%29.2+1-2+rpi1~1^2~324^2~1605 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:///%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:/?a=commitdiff_plain;h=aead30b5ae76af1aa8dfd440ba0a7a40f4e15c77;p=emacs.git Standardize on VIRT_ADDR_VARIES behavior. Otherwise, valgrind does not work on some platforms. Problem reported by Andreas Schwab in . * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES is set, removing the need for VIRT_ADDRESS_VARIES. (PURE_P): Use a more-efficient implementation that needs just one comparison, not two: on x86-64 with GCC 4.6.2, this cut down the number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge) to 4 (xorl, subq, cmpq, setbe). * alloc.c (pure): Always extern now, since that's the VIRT_ADDR_VARIES behavior. (PURE_POINTER_P): Use a single comparison, not two, for consistency with the new puresize.h. * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed. * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h: Remove VIRT_ADDR_VARIES no longer needed. --- aead30b5ae76af1aa8dfd440ba0a7a40f4e15c77 diff --cc src/ChangeLog index fb5eef08b7f,5424e5b938b..acf2bb83e2b --- a/src/ChangeLog +++ b/src/ChangeLog @@@ -1,3 -1,22 +1,23 @@@ + 2011-11-20 Paul Eggert + - Standardize on VIRT_ADDR_VARIES behavior; otherwise, valgrind - does not work on some platforms. Problem reported by Andreas Schwab in ++ Standardize on VIRT_ADDR_VARIES behavior (Bug#10042). ++ Otherwise, valgrind does not work on some platforms. ++ Problem reported by Andreas Schwab in + . + * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES + is set, removing the need for VIRT_ADDRESS_VARIES. + (PURE_P): Use a more-efficient implementation that needs just one + comparison, not two: on x86-64 with GCC 4.6.2, this cut down the + number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge) + to 4 (xorl, subq, cmpq, setbe). + * alloc.c (pure): Always extern now, since that's the + VIRT_ADDR_VARIES behavior. + (PURE_POINTER_P): Use a single comparison, not two, for + consistency with the new puresize.h. + * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed. + * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h: + Remove VIRT_ADDR_VARIES no longer needed. + 2011-11-19 Eli Zaretskii * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)